[PATCH] make cmakeduchaintest run without asserts
david.nolden.kdevelop at art-master.de
Sat May 23 23:05:10 UTC 2009
Am Samstag 23 Mai 2009 23:18:05 schrieb Peter Oberndorfer:
> vm.insert CMAKE_CURRENT_SOURCE_DIR is needed since 953842
> where a Q_ASSERT was added to make sure CMAKE_CURRENT_SOURCE_DIR is defined
> addDocumentChain in testUses is needed to avoid assert indexed.data() ==
> context in removeDocumentChain that fires when a addDocumentChain was never
> addDocumentChain + removeDocumentChain testDUChainWalk
> are needed to avoid assert m_recursiveImports.isEmpty()
> in TopDUContextLocalPrivate::clearImportedContextsRecursively
> I am no duchain/cmake expert, so please review carefully.
> Also i don't know if addDocumentChain + removeDocumentChain
> is the right cure for the m_recursiveImports.isEmpty() assert.
Your duchain fixes are correct. A top-context is only partially functional
when it was not added using addDocumentChain.
More information about the KDevelop-devel