[apaku at gmx.de: Re: KDE/kdevplatform]

[Andreas Pakulat]

On 20.05.09 16:39:34, David Nolden wrote:
> Am Mittwoch 20 Mai 2009 16:29:22 schrieb Andreas Pakulat:
> > Ooops, this wasn't meant for the user list.
> >
> > ----- Forwarded message from Andreas Pakulat <apaku at gmx.de> -----
> >
> > Delivery-date: Wed, 20 May 2009 16:00:04 +0200
> > From: Andreas Pakulat <apaku at gmx.de>
> > To: kdevelop at kdevelop.org
> > Subject: Re: KDE/kdevplatform
> > Reply-To: kdevelop at kdevelop.org
> >
> > On 19.05.09 23:14:52, David Nolden wrote:
> > > SVN commit 970297 by zwabel:
> > >
> > > - Add a new function to the UI Controller that makes sure that at least
> > > one toolview of the type exists in the current active area, returns that
> > > tool-view, and also allows raising it.
> > >
> > > This allows plugins that need to activate a toolview to do that in a
> > > clean way. Also this allows easier working with multiple main windows and
> > > areas for plugins.
> >
> > Hmm, why is this on the uicontroller and not the mainwindow? After all you
> > don't really want to raise a toolview on all mainwindows, you want to raise
> > it on the active one.
> Yep and that's what happens. But from what I see, Sublime::MainWindow is not 
> exposed to plugins, so how else should it be made accessible?

What do you mean with 'not exposed'? The fact that activeMainWindow() just
return KParts::Mainwindow? You can still cast that one to a
Sublime::MainWindow, but we can also change the return type of
activeMainWindow(). 

The API however should be on Sublime::Area as far as I understood, so
plugins would need to do 

uiController()->activeMainWindow()->area()->findToolView()

Oh and why are we supplying raise-support? After all thats already
available by calling View::requestRaise(); So in fact I think we should
have findToolView( bool create = false ) on Sublime::Area and plugins can
then do

...findToolView( true )->requestRaise();

Or just get the toolview if they want just that.

Andreas

-- 
You'll be called to a post requiring ability in handling groups of people.