Review-Request: UnsureType::addType for unique-lists

David Nolden david.nolden.kdevelop at art-master.de
Mon May 11 16:40:18 UTC 2009


Am Montag 11 Mai 2009 17:34:39 schrieb Milian Wolff:
> Hey guys!
>
> At least for return-types it doesn't make much sense imo to add the same
>   type multiple times to the UnsureType, example:
I also think that this should not even be optional. Just make sure that every 
type is added just once.

Also, the types should be ordered by index at some point, so that 
UnsureType(Bool, Int) will not be a different type than UnsureType(Int, Bool), 
and so the check whether the type is already in the list can be made more 
efficient.

Anyway for now it should be ok to just add the check, and then just commit it.

Greetings, David





More information about the KDevelop-devel mailing list