KDE/kdevplatform

[David Nolden]

Am Sonntag 10 Mai 2009 23:47:14 schrieb Amilcar do Carmo Lucas:
> SVN commit 966293 by aclu:
>
> Krazy
>
>  M  +1 -1      plugins/subversion/svninternaljobbase.cpp
>  M  +1 -1      util/executecompositejob.h
>  M  +1 -1      vcs/dvcs/dvcsplugin.cpp
>
>
> --- trunk/KDE/kdevplatform/plugins/subversion/svninternaljobbase.cpp
> #966292:966293 @@ -170,7 +170,7 @@
>                  sendFirstDelta = false;
>                  notifyString=i18n("Transmitting file data ");
>              } else {
> -                notifyString=".";
> +                notifyString='.';
>              }
>              break;
>          case svn_wc_notify_blame_revision:
> --- trunk/KDE/kdevplatform/util/executecompositejob.h #966292:966293
> @@ -33,7 +33,7 @@
>  public:
>      ExecuteCompositeJob(QObject* parent, const QList<KJob*>& jobs);
>      virtual void start();
> -public slots:
> +public Q_SLOTS:
>      virtual void slotResult(KJob* job);
>  protected:
>      virtual bool doKill();
> --- trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.cpp #966292:966293
> @@ -425,7 +425,7 @@
>              file = url.toLocalFile();
>
>          if (file.isEmpty())
> -            file = ".";
> +            file = '.';
>
>          args << file;
>          kDebug() << "url is: " << url << "job->getDirectory(): " <<
> workingDir << " file is: " << file;

I've got to say, I don't like this specific kind of krazy fixes.

- Q_SLOTS is plain ugly
- assigning a character to a string may be allowed in the case of QString, but 
semantically it's wrong and ugly, and additionally to that we've already seen 
such changes cause new bugs. It's a micro optimization that is irrelevant in 
these use-cases, and I think it shouldn't be done on a general basis, given 
the disadvantages (Chance of new bugs, semantic wrongness)

Greetings, David