Review Request: Common Debugger infrastructure

[Niko Sams]

> On 2009-03-23 11:41:31, Andreas Pakulat wrote:
> > trunk/KDE/kdevplatform/debugger/interfaces/idebugsession.h, line 29
> > <http://reviewboard.kde.org/r/379/diff/2/?file=3493#file3493line29>
> >
> >     Why is this class a QObject? You can just as well define just the interface class (even include the Q_SLOTS and Q_SIGNALS macros) and make all member functions pure virtual. That way you don't need to add a library just for having and empty constructor and destructor.

will change that.


> On 2009-03-23 11:41:31, Andreas Pakulat wrote:
> > trunk/KDE/kdevplatform/debugger/shell/debuggershellplugin.cpp, line 82
> > <http://reviewboard.kde.org/r/379/diff/2/?file=3497#file3497line82>
> >
> >     Hmm, strings for state's? What happened to enums :)

this is a call to KXMLGUIClient::stateChanged to disable/enable various actions :D


> On 2009-03-23 11:41:31, Andreas Pakulat wrote:
> > trunk/KDE/kdevplatform/debugger/shell/debuggershellplugin.h, line 38
> > <http://reviewboard.kde.org/r/379/diff/2/?file=3496#file3496line38>
> >
> >     Unless I'm mistaken this controller should be part of the shell itself and not a separate plugin. Also makes it easier for actual debuggers to add a session as they don't need to search for a specific plugin with a specific name.

that would be the whole debugger user interface - right?
this will get quite large...


- Niko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/379/#review573
-----------------------------------------------------------


On 2009-03-21 14:46:23, Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/379/
> -----------------------------------------------------------
> 
> (Updated 2009-03-21 14:46:23)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> - IDebugController: has just one slot to add a Debug-Session, debuggers/shell implements this interface.
>   Debugger-plugins search for the debuggers/shell plugin and call IDebugController::addSession when
>   a debug session is started.
> - IDebugSession: debugger plugin inherits from this class to use the debugger UI and communicate
>   with the debuggers/shell plugin.
> 
> Currenly only the various actions are implemented; Breakpoints, Variable-Views, Stack-Views etc.
> should be possible in a similar way.
> 
> Please review my ideas and tell me if I go into a wrong direction - or what could be improved.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdevplatform/CMakeLists.txt 941839 
>   trunk/KDE/kdevplatform/KDevPlatformConfig.cmake.in 941839 
>   trunk/KDE/kdevplatform/cmake/modules/FindKDevPlatform.cmake 941839 
>   trunk/KDE/kdevplatform/debugger/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdevplatform/debugger/debuggerexport.h PRE-CREATION 
>   trunk/KDE/kdevplatform/debugger/interfaces/idebugsession.h PRE-CREATION 
>   trunk/KDE/kdevplatform/debugger/interfaces/idebugsession.cpp PRE-CREATION 
>   trunk/KDE/kdevplatform/debugger/shell/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdevplatform/debugger/shell/debuggershellplugin.h PRE-CREATION 
>   trunk/KDE/kdevplatform/debugger/shell/debuggershellplugin.cpp PRE-CREATION 
>   trunk/KDE/kdevplatform/debugger/shell/kdevdebuggershell.desktop PRE-CREATION 
>   trunk/KDE/kdevplatform/debugger/shell/kdevdebuggershellui.rc PRE-CREATION 
>   trunk/KDE/kdevplatform/interfaces/CMakeLists.txt 941839 
>   trunk/KDE/kdevplatform/interfaces/idebugcontroller.h PRE-CREATION 
>   trunk/KDE/kdevplatform/interfaces/idebugcontroller.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/379/diff
> 
> 
> Testing
> -------
> 
> ported the xdebug plugin
> 
> 
> Thanks,
> 
> Niko
> 
>