Review Request: Reuse of URL field in VCSLocation for repository locations (Includes changes from "DVCS: Escape...")

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/389/#review568
-----------------------------------------------------------



/trunk/KDE/kdevplatform/vcs/vcslocation.h
<http://reviewboard.kde.org/r/389/#comment343>

    Hmm, I actually was under the impression we'd just remove the "local" from setLocalUrl/localUrl as its redundant as the information is contained in the type already.
    
    I don't think I want it to be possible to use url's for repositories at this point.


- Andreas


On 2009-03-22 07:24:05, Fabian Wiesel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/389/
> -----------------------------------------------------------
> 
> (Updated 2009-03-22 07:24:05)
> 
> 
> Review request for KDevelop and Andreas Pakulat.
> 
> 
> Summary
> -------
> 
> This patch allows one to use the url field of VcsLocation also for (remote) repository locations.
> Unfortunately the patch includes the changes of "DVCS: Escape filenames beginning with a hyphen" as changes touch the same files.
> 
> - Rename the getter (and the corresponding field) localUrl() to url.
> - Added additional setter for setRepositoryUrl()
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevplatform/plugins/appwizard/appwizardplugin.cpp 942616 
>   /trunk/KDE/kdevplatform/plugins/cvs/cvsplugin.cpp 942616 
>   /trunk/KDE/kdevplatform/plugins/cvs/importmetadatawidget.cpp 942616 
>   /trunk/KDE/kdevplatform/plugins/git/gitplugin.cpp 942616 
>   /trunk/KDE/kdevplatform/plugins/mercurial/CMakeLists.txt 942616 
>   /trunk/KDE/kdevplatform/plugins/mercurial/mercurialplugin.cpp 942616 
>   /trunk/KDE/kdevplatform/plugins/subversion/svncatjob.cpp 942616 
>   /trunk/KDE/kdevplatform/plugins/subversion/svncheckoutjob.cpp 942616 
>   /trunk/KDE/kdevplatform/plugins/subversion/svndiffjob.cpp 942616 
>   /trunk/KDE/kdevplatform/plugins/subversion/svnimportjob.cpp 942616 
>   /trunk/KDE/kdevplatform/plugins/subversion/svnimportmetadatawidget.cpp 942616 
>   /trunk/KDE/kdevplatform/shell/kross/krossdistributedversioncontrol.cpp 942616 
>   /trunk/KDE/kdevplatform/shell/kross/wrappers/krossvcslocation.cpp 942616 
>   /trunk/KDE/kdevplatform/vcs/CMakeLists.txt 942616 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/importmetadatawidget.cpp 942616 
>   /trunk/KDE/kdevplatform/vcs/vcslocation.h 942616 
>   /trunk/KDE/kdevplatform/vcs/vcslocation.cpp 942616 
>   /trunk/KDE/kdevplatform/vcs/vcsmapping.cpp 942616 
>   /trunk/KDE/kdevplatform/vcs/widgets/vcsdiffwidget.cpp 942616 
> 
> Diff: http://reviewboard.kde.org/r/389/diff
> 
> 
> Testing
> -------
> 
>   1/  3 Testing kdevcvs-test                     Passed
>   2/  3 Testing kdevgit-test                     Passed
>   3/  3 Testing kdevmercurial-test               Passed
> 
> 100% tests passed, 0 tests failed out of 3
> 
>   1/  2 Testing dvcsTest                         Passed
>   2/  2 Testing vcsBlackBoxTest                  Passed
> 
> 100% tests passed, 0 tests failed out of 2
> 
> 
> Thanks,
> 
> Fabian
> 
>