Review Request: Class browser re-design

Hamish Rodda rodda at kde.org
Sun Mar 22 22:57:12 UTC 2009


Hi,

On Saturday 21 March 2009 21:05:31 Lior Mualem wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/376/
> -----------------------------------------------------------
>
> Review request for KDevelop.
>
>
> Summary
> -------
>
> Almost a complete re-write of the class model.
> I did it mostly because I wanted to move the logic away from the model and
> into the node class. This will eventually allow for greater flexibility
> with different node types and different operations for each node type - Two
> examples would be the BaseClassesFolderNode and the
> DerivedClassesFolderNode, both which implements an informative view for the
> node that they belong to.
>
> Also implemented is a dynamic population of the nodes in the tree -
> information is retrieved only when needed and when the node is collapsed,
> it's sub-items are cleared (only for dynamic nodes which is most of the
> nodes).
>
> Some stuff still left to be done before it's considered usable (in my
> opinion anyway): * Updates - I don't perform any update at the moment, once
> a project is loaded, it stays that way (one way around it is to collapse
> the node and re-expand it. It will force a refresh). * Search capabilities
> - I plan on having a special "Search results" node which will show the
> results for the current search.

I had a look at the diff but it's basically useless for me to do so, due to the 
rewrite.

Do you plan to take over maintenance of the class browser?  If so I'd say you 
should branch the current class browser code and work in a different 
subdirectory, and when your code is ready/feature complete we can test it 
then.

Cheers,
Hamish.




More information about the KDevelop-devel mailing list