Review Request: DVCS: Escape filenames beginning with a hyphen

[Evgeniy Ivanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/385/#review552
-----------------------------------------------------------

Ship it!


Thanks, code looks fine.

- Evgeniy


On 2009-03-22 03:12:24, Fabian Wiesel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/385/
> -----------------------------------------------------------
> 
> (Updated 2009-03-22 03:12:24)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Filenames may begin with a hyphen. I order to differentiate between files and options, the usual solution is the escape-sequence "--", after which everything is a file.
> Changed git- and mercurial-plug-in accordingly.
> 
> Also, somewhat unrelated, cleanup the Mercurial-plug-in and give it its own debug channel.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevplatform/plugins/mercurial/mercurialplugin.cpp 942015 
>   /trunk/KDE/kdevplatform/plugins/mercurial/CMakeLists.txt 942015 
>   /trunk/KDE/kdevplatform/plugins/git/gitplugin.cpp 942015 
> 
> Diff: http://reviewboard.kde.org/r/385/diff
> 
> 
> Testing
> -------
> 
>   1/  3 Testing kdevcvs-test                     Passed
>   2/  3 Testing kdevgit-test                     Passed
>   3/  3 Testing kdevmercurial-test               Passed
> 
> 100% tests passed, 0 tests failed out of 3
> 
> 
> Thanks,
> 
> Fabian
> 
>