Review Request: KDevelop::Core::NoUi fixes

[Andreas Pakulat]

> On 2009-03-16 15:13:14, Andreas Pakulat wrote:
> > trunk/KDE/kdevelop/debuggers/gdb/ibreakpointcontroller.cpp, line 27
> > <http://reviewboard.kde.org/r/345/diff/1/?file=3136#file3136line27>
> >
> >     Same thing here, shell cannot be used anywhere except when building the actual executable. So either remove any GUI dependencies from ibreakpointcontroller or don't use it in non-gui tests.
> 
>  wrote:
>     would it be possible to move Core::Setup to ICore::Setup?

No, its an implementation detail of the shell, nothing a plugin should need to know about. As I said either IBreakPointController is a non-gui class or a gui class, the latter obviously limitting its usability in non-gui code.


> On 2009-03-16 15:13:14, Andreas Pakulat wrote:
> > trunk/KDE/kdevplatform/shell/documentationcontroller.cpp, line 78
> > <http://reviewboard.kde.org/r/345/diff/1/?file=3139#file3139line78>
> >
> >     This has already been done, IIRC.
> 
>  wrote:
>     hmm, don't think so - that must be something different.
>     But it is ok - right?

Indeed, I thought that was part of some earlier commit.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/345/#review504
-----------------------------------------------------------


On 2009-03-16 12:43:20, Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/345/
> -----------------------------------------------------------
> 
> (Updated 2009-03-16 12:43:20)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Needed to get my UnitTest working.
> (that initializes Core with NoUi)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdevelop/debuggers/gdb/CMakeLists.txt 940158 
>   trunk/KDE/kdevelop/debuggers/gdb/ibreakpointcontroller.cpp 940158 
>   trunk/KDE/kdevelop/debuggers/valgrind/CMakeLists.txt 940158 
>   trunk/KDE/kdevelop/debuggers/valgrind/valgrindplugin.cpp 940158 
>   trunk/KDE/kdevplatform/shell/documentationcontroller.cpp 940158 
> 
> Diff: http://reviewboard.kde.org/r/345/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Niko
> 
>