Review Request: KDevelop::Core::NoUi fixes

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/345/#review504
-----------------------------------------------------------



trunk/KDE/kdevelop/debuggers/gdb/ibreakpointcontroller.cpp
<http://reviewboard.kde.org/r/345/#comment293>

    Same thing here, shell cannot be used anywhere except when building the actual executable. So either remove any GUI dependencies from ibreakpointcontroller or don't use it in non-gui tests.



trunk/KDE/kdevelop/debuggers/valgrind/CMakeLists.txt
<http://reviewboard.kde.org/r/345/#comment292>

    This is a no-go. No plugin is allowed to ever link against shell. Shell is an implementation detail of the platform thats not exposed - except for the main.cpp of the actual application.



trunk/KDE/kdevelop/debuggers/valgrind/valgrindplugin.cpp
<http://reviewboard.kde.org/r/345/#comment291>

    This is not needed, valgrind plugin should just be declared a gui plugin, because it simply is one.



trunk/KDE/kdevplatform/shell/documentationcontroller.cpp
<http://reviewboard.kde.org/r/345/#comment290>

    This has already been done, IIRC.


- Andreas


On 2009-03-16 12:43:20, Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/345/
> -----------------------------------------------------------
> 
> (Updated 2009-03-16 12:43:20)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Needed to get my UnitTest working.
> (that initializes Core with NoUi)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdevelop/debuggers/gdb/CMakeLists.txt 940158 
>   trunk/KDE/kdevelop/debuggers/gdb/ibreakpointcontroller.cpp 940158 
>   trunk/KDE/kdevelop/debuggers/valgrind/CMakeLists.txt 940158 
>   trunk/KDE/kdevelop/debuggers/valgrind/valgrindplugin.cpp 940158 
>   trunk/KDE/kdevplatform/shell/documentationcontroller.cpp 940158 
> 
> Diff: http://reviewboard.kde.org/r/345/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Niko
> 
>