Review Request: Moved ClassDeclaration from KDevelop into KDevPlatform

[David Nolden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/316/#review480
-----------------------------------------------------------

Ship it!


Good  job, looks fine.
But before committing it: Whenever doing something language-specific, please also make sure all the tests compile and pass. Specifically  kdevelop/languages/cpp/cppduchain/duchaintest, kdevelop/languages/cpp/cppduchain/expressionparsertest, and kdevelop/languages/cpp/tests/cppcodecompletiontest.

- David


On 2009-03-15 07:19:49, Lior Mualem wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/316/
> -----------------------------------------------------------
> 
> (Updated 2009-03-15 07:19:49)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Moved ClassDeclaration from KDevelop into KDevPlatform as it's needed by many languages (and I need it for the class browser).
> Also merged Cpp::DeclarationNavigationContext::htmlClass into AbstractDeclarationNavigationContext::htmlClass function - KDevPlatform has knowledge of the ClassDeclaration so there's no reason why it shouldn't be able to print out the class name and type (I actually fixed a todo in there :D ).
> 
> I guess there's more support code which can also be moved to KDevPlatform but I don't know enough in that area to do that. 
> Maybe the language developers could gradually move the code around so it could be shared among everyone.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevelop/languages/cpp/codecompletion/item.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/codecompletion/missingincludeitem.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/codegen/cppnewclass.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/cppduchain/CMakeLists.txt 939540 
>   /trunk/KDE/kdevelop/languages/cpp/cppduchain/classdeclaration.h 939540 
>   /trunk/KDE/kdevelop/languages/cpp/cppduchain/classdeclaration.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/cppduchain/contextbuilder.h 939540 
>   /trunk/KDE/kdevelop/languages/cpp/cppduchain/contextbuilder.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/cppduchain/cppduchain.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/cppduchain/declarationbuilder.h 939540 
>   /trunk/KDE/kdevelop/languages/cpp/cppduchain/declarationbuilder.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/cppduchain/navigation/declarationnavigationcontext.h 939540 
>   /trunk/KDE/kdevelop/languages/cpp/cppduchain/navigation/declarationnavigationcontext.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/cppduchain/sourcemanipulation.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/cppduchain/templatedeclaration.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/cppduchain/tests/test_duchain.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/cppduchain/typeutils.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/tests/test_cppcodecompletion.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/veritas/stubconstructor.h 939540 
>   /trunk/KDE/kdevelop/languages/cpp/veritas/stubconstructor.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/veritas/stubcontextaction.h 939540 
>   /trunk/KDE/kdevelop/languages/cpp/veritas/stubcontextaction.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/veritas/tests/classdeclarationfactory.h 939540 
>   /trunk/KDE/kdevelop/languages/cpp/veritas/tests/classdeclarationfactory.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/veritas/tests/stubcreationtest.cpp 939540 
>   /trunk/KDE/kdevelop/languages/cpp/veritas/uutcontextaction.cpp 939540 
>   /trunk/KDE/kdevplatform/language/CMakeLists.txt 939543 
>   /trunk/KDE/kdevplatform/language/duchain/classdeclaration.h 939543 
>   /trunk/KDE/kdevplatform/language/duchain/classdeclaration.cpp 939543 
>   /trunk/KDE/kdevplatform/language/duchain/navigation/abstractdeclarationnavigationcontext.cpp 939543 
> 
> Diff: http://reviewboard.kde.org/r/316/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lior
> 
>