Review Request: Fixes for Core::initialize(NoGui), added LoadNoPlugins flag for testing plugins

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/331/#review484
-----------------------------------------------------------


The NoUi flag is actually there so that no mainwindow is created. The uicontroller should still be instantiaged. So that part of the patch is wrong.

Regarding the loading of plugins, loadPluginInternal checks wether a plugin is a ui-plugin or not and refuses loading it. I've put two fixes into plugincontroller that make sure that if for a given plugin X any of its dependencies cannot be loaded then X is also not loaded.

- Andreas


On 2009-03-15 10:46:17, Fabian Wiesel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/331/
> -----------------------------------------------------------
> 
> (Updated 2009-03-15 10:46:17)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> The UIController may not be created, since there is the Core::Setup::NoGUI-flag for testing purposes.
> The documentation controller didn't expect this and crashes. This should be fixed with the patch attached.
> 
> Also, when testing a plugin, other plugins may rely on the existance of UIController, too.
> To avoid complications, I introduced the LoadNoPlugins flag, which disables
> the automated loading of plugins by not calling PluginController::initialize().
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevplatform/shell/core.h 939529 
>   /trunk/KDE/kdevplatform/shell/core.cpp 939529 
>   /trunk/KDE/kdevplatform/shell/documentationcontroller.cpp 939529 
>   /trunk/KDE/kdevplatform/shell/documentcontroller.cpp 939529 
> 
> Diff: http://reviewboard.kde.org/r/331/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fabian
> 
>