KDE/kdevplatform/language/duchain/repositories

[Andreas Pakulat]

On 15.03.09 02:03:51, David Nolden wrote:
> Am Sonntag 15 März 2009 01:31:25 schrieb Andreas Pakulat:
> > On 14.03.09 23:44:07, Andrew Coles wrote:
> > > SVN commit 939501 by coles:
> > >
> > > Got rid of many many many warnings if Q_ASSERT is disabled, and hence
> > > several variables are unused in each instantiation of the template.
> >
> > I don't like this commit at all, it uglifies the code a lot with those
> > QT_NO_DEBUG statements. We need to find a better way of avoiding those
> > warnings.
> >
> > Andreas
> 
> I agree. Readable code is more important than the warnings, so we should just 
> revert this patch and not care about them. These "#ifdef"s make it really a 
> lot more ugly than it should be.

Having to work with Qt3 and current gcc I think thats not an option either.
Such warnings, especially when there are a lot of them can:

- hide more important warnings
- make it harder to find real compiler errors

Andreas
 
-- 
It was all so different before everything changed.