Review Request: KDevPlatform Mercurial plugin v2

[Fabian Wiesel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/300/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

This is the second version of my attempt at a Mercurial plugin

I adopted in DVCSjob::output() the logic from ProcessLineMaker for converting the raw output to QString. Note: Logic will fail in 16-bit charsets (or larger) environments (Windows Unicode).

IBasicVersionControl is implemented insofar, that all functions called by the context-menu are working (at least for me). Especially the diff-function may fail, if called a different way than the context-menu does.

"Head" and "Base" map to the latest locally commit revision.

Functions not directly callable by the context menu are implemented, but untested.

The following functions are not implemented:
- update() 
- merge()

IDistributedVersionControl has been implemented except for:
- add_dvcs() as it would the same as IBasicVersionControl::add()

IDVCSexecutor::branch() is only as so far implemented, that one can create a branch from the currently checked out branch/version.
Deleting a branch is not possible with the Mercurial version I have.


Diffs
-----

  /trunk/KDE/kdevplatform/plugins/CMakeLists.txt 939198 
  /trunk/KDE/kdevplatform/plugins/git/gitexecutor.h 939198 
  /trunk/KDE/kdevplatform/plugins/git/gitexecutor.cpp 939198 
  /trunk/KDE/kdevplatform/plugins/mercurial/CMakeLists.txt PRE-CREATION 
  /trunk/KDE/kdevplatform/plugins/mercurial/Messages.sh PRE-CREATION 
  /trunk/KDE/kdevplatform/plugins/mercurial/kdevmercurial.desktop PRE-CREATION 
  /trunk/KDE/kdevplatform/plugins/mercurial/kdevmercurial.rc PRE-CREATION 
  /trunk/KDE/kdevplatform/plugins/mercurial/mercurialexecutor.h PRE-CREATION 
  /trunk/KDE/kdevplatform/plugins/mercurial/mercurialexecutor.cpp PRE-CREATION 
  /trunk/KDE/kdevplatform/plugins/mercurial/mercurialplugin.h PRE-CREATION 
  /trunk/KDE/kdevplatform/plugins/mercurial/mercurialplugin.cpp PRE-CREATION 
  /trunk/KDE/kdevplatform/plugins/mercurial/tests/CMakeLists.txt PRE-CREATION 
  /trunk/KDE/kdevplatform/plugins/mercurial/tests/initTest.h PRE-CREATION 
  /trunk/KDE/kdevplatform/plugins/mercurial/tests/initTest.cpp PRE-CREATION 
  /trunk/KDE/kdevplatform/vcs/dvcs/dvcsjob.h 939198 
  /trunk/KDE/kdevplatform/vcs/dvcs/dvcsjob.cpp 939198 
  /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.h 939198 
  /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.cpp 939198 
  /trunk/KDE/kdevplatform/vcs/dvcs/idvcsexecutor.h 939198 
  /trunk/KDE/kdevplatform/vcs/dvcs/idvcsexecutor.cpp 939198 
  /trunk/KDE/kdevplatform/vcs/dvcs/ui/logview.cpp 939198 

Diff: http://reviewboard.kde.org/r/300/diff


Testing
-------


Thanks,

Fabian