Patch for preliminary Mercurial integration in kdevplatform

[Andreas Pakulat]

On 14.03.09 01:01:38, Evgeniy Ivanov wrote:
> On Sat March 14 2009 00:14:50 Andreas Pakulat wrote:
> > On 09.03.09 09:07:22, Fabian Wiesel wrote:
> > > First, DVCSjob is changed from parsing the output for lines and later
> > > rejoining them to a single string to simply accumulating a QByteArray.
> >
> > While thats fine in general it puts a lot of burden onto the plugin
> > writer as he has to convert the bytearray into a string. If you look at
> > ProcessLineMaker in utils you'll see that thats not quite as easy as one
> > might think. Individual comments below.
> 
> But in some cases, using QByteArray can improve perfomance. QGit uses mostly 
> uses QByteArray, but with somethings you mention bellow to avoid problems (and 
> QGit developer wrote it really improves perfomance). I still plan to port some 
> QGit's code, which can be shared between these plugins, but circumstances 
> don't let me... 

I was merely pointing out that you'll have to do a bit more thinking
when using plain qbytearray instead of the processlinemaker. If its
faster to read larger chunks of data and not split them on lines its of
course fine to use qbytearray, just make sure you get the encoding
right.
 
> Look's ok to me too. Except the thing, that big part duplicates hg plugin from 
> utils (but some extra functions are implemented, so it should support 
> revhistory view).

Well, thats to be expected, apparently Fabian didn't know about the
playground plugin and if he's willing to maintain the code in
kdevplatform the plugin in playground can be deleted.

Andreas

-- 
Change your thoughts and you change your world.