Review Request: possible null pointer crash

[Frederik Schwarzer]

> On 2009-03-05 03:54:40, David Nolden wrote:
> > There should be no error in those cases, it just should not crash. The new-class wizard can also be started without a project-tree item(From the main menu)

So either item->folder() or item->target() is always true and item->folder() and item->parent())->folder() respectively is always returning a valid folder? If that is guaranteed, it is ok as is.


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/234/#review360
-----------------------------------------------------------


On 2009-03-05 03:08:07, Frederik Schwarzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/234/
> -----------------------------------------------------------
> 
> (Updated 2009-03-05 03:08:07)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> I found a pointer which gets its value either in an if() or an else if() block.
> Honestly, I do not really know how the code around there works but Andreas ordered me to post something here, so I did. ;)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevelop/languages/cpp/codegen/simplerefactoring.cpp 935489 
> 
> Diff: http://reviewboard.kde.org/r/234/diff
> 
> 
> Testing
> -------
> 
> Compiled and ran the new class action.
> 
> 
> Thanks,
> 
> Frederik
> 
>