KDE/kdevplatform/shell

[Andreas Pakulat]

On 08.06.09 21:03:24, David Nolden wrote:
> Am Montag 08 Juni 2009 20:39:02 schrieb Andreas Pakulat:
> > On 08.06.09 18:25:33, David Nolden wrote:
> > > Am Montag 08 Juni 2009 17:22:30 schrieb Andreas Pakulat:
> > > > SVN commit 978934 by apaku:
> > > >
> > > > Disable creation of the workingset widget for Qt < 4.5 as we don't have
> > > > a place for it in that version. Unfortunately I still get something
> > > > displayed in the upper-left corner of the mainwindow, but no idea where
> > > > that widget comes from.
> > > > David any idea?
> > > > CCMAIL:kdevelop-devel at kdevelop.org
> > >
> > > How does that thing look you see up there?
> >
> > Its dark-blue, has an icon and looks a bit like a button. I'll make a
> > screenshot tomorrow.
> >
> > I tried to remove that by moving all code thats remotely related to the
> > area-switcher into #if QT_VERSION but either I failed or there's
> > something else going on.
> >
> > Andreas
> Either it's the set-manager widget, see mainwindow.cpp:61,

Well, that part is also dead with qt4.4 as I've made the
createSetManagerWidget function return 0 in that case.

> or more probably, 
> it's a working-set icon, which is created at mainwindow.cpp:55. But then it's 
> strange, because that is called from within code that you commented out. Maybe 
> just place a Q_ASSERT(0) into WorkingSetController::createSetManagerWidget, to 
> see from where it's created.

I'll try to fiddle around a bit more tomorrow. If I can't find anything
I'll probably declare Qt4.5 as required (most distro's seem to ship
recent KDE4.2 with Qt4.5 already) and adjust the cmake checks (and
remove the #if's)

Andreas

-- 
You will be awarded a medal for disregarding safety in saving someone.