Review Request: Extract class code generation from the create class wizard

David Nolden zwabel+reviewboard at gmail.com
Tue Jun 2 13:42:36 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/778/#review1256
-----------------------------------------------------------

Ship it!


I'm not familiar with the code, so I just trust Hamishs review.

However, you should concentrate on the core parts of your SOC now. This is not really related, and was mainly ment as an entry point, but you should be working in other areas now.

- David


On 2009-06-01 18:55:11, Ramón Zarazúa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/778/
> -----------------------------------------------------------
> 
> (Updated 2009-06-01 18:55:11)
> 
> 
> Review request for KDevelop, David Nolden and Hamish Rodda.
> 
> 
> Summary
> -------
> 
> Extract the class generating code from the wizard. This way code generators can invoke a class generator by themselves. This first version just extracts the code generation from the wizard. Afterwards it will be generating code using the DUChainChangeSet & AstChangeSet. I need feedback to know if I should continue along.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdevplatform/language/codegen/createclass.h 974612 
>   trunk/KDE/kdevplatform/language/codegen/createclass.cpp 974612 
>   trunk/KDE/kdevplatform/language/codegen/overridespage.h 974612 
>   trunk/KDE/kdevplatform/language/codegen/overridespage.cpp 974612 
> 
> Diff: http://reviewboard.kde.org/r/778/diff
> 
> 
> Testing
> -------
> 
> The code is not done yet, it doesn't even compile, I am extracting the inheritance build code.
> 
> 
> Thanks,
> 
> Ramón
> 
>





More information about the KDevelop-devel mailing list