Review Request: Extract class code generation from the create class wizard

Hamish Rodda rodda at kde.org
Mon Jun 1 01:26:50 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/778/#review1246
-----------------------------------------------------------


Looks good in principle.  Probably we'd want to split the two classes into separate files at some point.

- Hamish


On 2009-05-29 11:33:36, Ramón Zarazúa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/778/
> -----------------------------------------------------------
> 
> (Updated 2009-05-29 11:33:36)
> 
> 
> Review request for KDevelop and David Nolden.
> 
> 
> Summary
> -------
> 
> Extract the class generating code from the wizard. This way code generators can invoke a class generator by themselves. This first version just extracts the code generation from the wizard. Afterwards it will be generating code using the DUChainChangeSet & AstChangeSet. I need feedback to know if I should continue along.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdevplatform/language/codegen/createclass.h 974187 
>   trunk/KDE/kdevplatform/language/codegen/createclass.cpp 974187 
> 
> Diff: http://reviewboard.kde.org/r/778/diff
> 
> 
> Testing
> -------
> 
> The code is not done yet, it doesn't even compile, I am extracting the inheritance build code.
> 
> 
> Thanks,
> 
> Ramón
> 
>





More information about the KDevelop-devel mailing list