KDE/kdevplatform/vcs/dvcs
Hugo Parente Lima
hugo.pl at gmail.com
Wed Jul 8 17:22:33 UTC 2009
On Wednesday 08 July 2009 13:59:59 David Nolden wrote:
> Am Mittwoch 08 Juli 2009 17:43:40 schrieb Alexander Dymo:
> > SVN commit 993377 by dymo:
> >
> > Unbreak git commit (and maybe other operations) - there was a bug
> > when kdevelop didn't add "/" between modified file path and name
> >
> >
> > M +1 -1 dvcsplugin.cpp
> >
> >
> > --- trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.cpp #993376:993377
> > @@ -400,7 +400,7 @@
> > {
> > QFileInfo repoInfo = QFileInfo(path);
> > if (repoInfo.isFile())
> > - return repoInfo.path();
> > + return repoInfo.path() + QDir::separator();
> > else if (path.endsWith(QDir::separator()))
> > return path;
> > else
>
> Seeing this I remember, isn't it wrong using QDir::separator, as Qt
> internally always uses '/'?
Yes, always yse '/' in the source code, QDir::separator is only usefull if you
need to known what your OS is using.
> Greetings, David
>
>
> _______________________________________________
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20090708/a11d89ef/attachment.sig>
More information about the KDevelop-devel
mailing list