Review last 3 changes to duchain

[David nolden]

Am Freitag 30 Januar 2009 00:17:45 schrieb Andreas Pakulat:
> Hi,
>
> I just checked in 3 changes for duchain to make kdev4 start up on win32 and
> like to have the expert(s) review them. In particular the moving of the
> KLockFile::unlock from after removeDirectory to before that in
> itemrepository.cpp.
>
> I think the last change is probably a no-brainer...
>
> Andreas

About the IndexedString change:
Why is it necessary to create that function? RepositoryManager only exists 
exactly for the same reason: To make the initialization-order stuff work 
better.
Cannout you somehow fix that issue within RepositoryManager? IndexedString is 
very performance critical, so additional function-calls should be prevented as 
much as possible.

About the added file unlock in itemrepository.cpp:
This leaves a very small danger window. I've made it write-lock the 
directory(this doesn't keep an open file) during that window, it should be ok 
like that.

Greetings, David