Review Request: Make Quick Open dialog be KDialog instead of QDialog

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/174/#review299
-----------------------------------------------------------

Ship it!


Patch is fine, except for the minimum size, thats just wrong.

- Andreas


On 2009-02-24 08:09:14, Dmitry Suzdalev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/174/
> -----------------------------------------------------------
> 
> (Updated 2009-02-24 08:09:14)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This patch makes quick open plugin use KDialog instead of QDialog for its dialog widget.
> 
> I made an ui file a simple QWidget and in cpp file just do
> 
> setupUi(m_dialog->mainWindow())
> 
> as needed for KDialog.
> 
> Also I set some sensible minimumSize for dialog (735x490)
> 
> 
> This addresses bug 181704.
>     https://bugs.kde.org/show_bug.cgi?id=181704
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdevplatform/plugins/quickopen/quickopen.ui 930794 
>   trunk/KDE/kdevplatform/plugins/quickopen/quickopenplugin.h 930794 
>   trunk/KDE/kdevplatform/plugins/quickopen/quickopenplugin.cpp 930794 
> 
> Diff: http://reviewboard.kde.org/r/174/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>