Review Request: documentation support in duchain navigation widget.

Matt Rogers mattr at kde.org
Thu Feb 19 14:41:45 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/123/#review167
-----------------------------------------------------------


I don't understand the description of this patch. What is actually supposed to do?


trunk/KDE/kdevplatform/language/duchain/navigation/abstractdeclarationnavigationcontext.cpp
<http://reviewboard.kde.org/r/123/#comment86>

    fix the whitespace.



trunk/KDE/kdevplatform/language/duchain/navigation/abstractdeclarationnavigationcontext.cpp
<http://reviewboard.kde.org/r/123/#comment85>

    If you're gonna add a comment like "//REMOVEME" then why did you put this in here in the first place? In this case, just don't add anything if there's no documentation to show.



trunk/KDE/kdevplatform/language/duchain/navigation/abstractdeclarationnavigationcontext.cpp
<http://reviewboard.kde.org/r/123/#comment87>

    fix the whitespace here too
    


- Matt


On 2009-02-18 15:06:46, Aleix Pol wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/123/
> -----------------------------------------------------------
> 
> (Updated 2009-02-18 15:06:46)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> When I click the link, I always get the header file, instead of the documentation (as i'd expect)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdevplatform/language/duchain/navigation/abstractdeclarationnavigationcontext.cpp 927980 
>   trunk/KDE/kdevplatform/language/duchain/navigation/abstractnavigationcontext.cpp 927980 
>   trunk/KDE/kdevplatform/language/duchain/navigation/navigationaction.h 927980 
> 
> Diff: http://reviewboard.kde.org/r/123/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix
> 
>





More information about the KDevelop-devel mailing list