Review Request: New Documentation Controller

Aleix Pol aleixpol at kde.org
Mon Feb 16 23:34:06 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/104/
-----------------------------------------------------------

(Updated 2009-02-16 15:34:06.394095)


Review request for KDevelop.


Summary
-------

I've been trying to get to have a simple documentation controller so that we can add all the stuff there as we discussed on this list.

Here it is attatched as a patch, I didn't directly commit it because I get this error:
ASSERT: "d" in file /home/kde-devel/kdelibs/kdecore/kernel/kcomponentdata.cpp, line 225
Aborted

If i comment the added method in icore.h it does work, it is a bit strange.

Any hint?


Diffs
-----

  trunk/KDE/kdevplatform/interfaces/CMakeLists.txt 926735 
  trunk/KDE/kdevplatform/interfaces/icore.h 926735 
  trunk/KDE/kdevplatform/interfaces/idocumentationcontroller.h PRE-CREATION 
  trunk/KDE/kdevplatform/shell/CMakeLists.txt 926735 
  trunk/KDE/kdevplatform/shell/core.h 926735 
  trunk/KDE/kdevplatform/shell/core.cpp 926735 
  trunk/KDE/kdevplatform/shell/core_p.h 926735 
  trunk/KDE/kdevplatform/shell/documentationcontroller.h PRE-CREATION 
  trunk/KDE/kdevplatform/shell/documentationcontroller.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/104/diff


Testing (updated)
-------

Ok, the problem was that I was not updating kdevelop properly, the code was fine. I'm committing it so that we can discuss what do we have to add there.


Thanks,

Aleix





More information about the KDevelop-devel mailing list