Review Request: Remove unused libs/headers from some plugins

David Nolden zwabel+reviewboard at gmail.com
Sun Feb 15 11:44:52 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/87/#review108
-----------------------------------------------------------


For some reason I cannot see the diffs, seems like the review-board isn't running properly. Anyway, removing the khtml stuff should be ok. I've used it for the navigation-widget at some point, and forgot removing it when switching to KTextBrowser.

- David


On 2009-02-15 03:40:33, Harald Fernengel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/87/
> -----------------------------------------------------------
> 
> (Updated 2009-02-15 03:40:33)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Some modules link to khtml, although they don't use it. In order to make a slimmer installation package for OS X, I'd like these dependencies removed.
> 
> Please shout out if you have strong feelings against that :)
> 
> 
> Diffs
> -----
> 
>   kdevelop/plugins/documentview/CMakeLists.txt 926170 
>   kdevelop/plugins/languages/cpp/CMakeLists.txt 926170 
>   kdevelop/plugins/languages/cpp/cppcodecompletionmodel.cpp 926170 
>   kdevelop/plugins/languages/cpp/tests/CMakeLists.txt 926170 
> 
> Diff: http://reviewboard.kde.org/r/87/diff
> 
> 
> Testing
> -------
> 
> It compiles on OS X
> 
> 
> Thanks,
> 
> Harald
> 
>





More information about the KDevelop-devel mailing list