Review Request: Compile KDevPlatform on Mac OS X

Andreas Pakulat apaku at gmx.de
Mon Feb 16 11:02:40 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/58/#review134
-----------------------------------------------------------


I suggest putting that into a gcc-specific ifdef for macos+win32, MSVC does provide a hash-function that works for that handle.

- Andreas


On 2009-02-16 02:45:25, Harald Fernengel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/58/
> -----------------------------------------------------------
> 
> (Updated 2009-02-16 02:45:25)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Compile duchainlock.cpp on Mac OS X. Qt::HANDLE is an unsigned long on Qt/X11, but a void * on Windows and Mac OS X. This patch adds a hash function for void *, which for some reason didn't exist.
> 
> Not that I know the internals of the hash that well, but from the error message, it seemed to be the only logical thing :)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdevplatform/language/duchain/duchainlock.cpp 925282 
> 
> Diff: http://reviewboard.kde.org/r/58/diff
> 
> 
> Testing
> -------
> 
> Tested on Mac OS X
> 
> 
> Thanks,
> 
> Harald
> 
>





More information about the KDevelop-devel mailing list