Review Request: Compile KDevPlatform on Mac OS X

[Matt Rogers]

On Fri, Feb 13, 2009 at 8:43 AM, Harald Fernengel <harry at kdevelop.org> wrote:
>
>
>> On 2009-02-13 00:08:16, Andreas Pakulat wrote:
>> > Unfortunately reviewboard needs a kdevplatform group before we can look at the diff. Sorry for messing that up, but for now you'll have to post the diff on the list or wait until I've reached the admin of reviewboard to request a new group.
>>
>> Andreas Pakulat wrote:
>>     Ooops, seems I was wrong. Harald, it seems you used the wrong base diff path. Trying to view the diff results in an error message telling me the file doesn't exist at kdevelop/language/duchain.
>
> Click on "Download Diff" for a manual review.
>
>
> - Harald
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/58/#review83
> -----------------------------------------------------------
>
>
> On 2009-02-12 15:20:39, Harald Fernengel wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://reviewboard.kde.org/r/58/
>> -----------------------------------------------------------
>>
>> (Updated 2009-02-12 15:20:39)
>>
>>
>> Review request for KDevelop.
>>
>>
>> Summary
>> -------
>>
>> Compile duchainlock.cpp on Mac OS X. Qt::HANDLE is an unsigned long on Qt/X11, but a void * on Windows and Mac OS X. This patch adds a hash function for void *, which for some reason didn't exist.
>>
>> Not that I know the internals of the hash that well, but from the error message, it seemed to be the only logical thing :)
>>
>>
>> Diffs
>> -----
>>
>>   kdevelop/language/duchain/duchainlock.cpp 925282
>>
>> Diff: http://reviewboard.kde.org/r/58/diff
>>
>>
>> Testing
>> -------
>>
>> Tested on Mac OS X
>>
>>
>> Thanks,
>>
>> Harald
>>
>>
>

sysadmin for reviewboard stuff. I help with that in addition to
bugzilla and the reviewboard admin is on the sysadmin list too.
--
Matt