KDE/kdevelop/plugins/managers/cmake/parser

[Andreas Pakulat]

On 11.02.09 18:26:08, Aleix Pol wrote:
> On Wed, Feb 11, 2009 at 5:56 PM, Andreas Pakulat <apaku at gmx.de> wrote:
> > On 11.02.09 16:32:48, Aleix Pol Gonzalez wrote:
> > > SVN commit 924800 by apol:
> > #924799:924800
> > > @@ -149,17 +149,20 @@
> > >              case EXISTS:
> > >              {
> > >                  QString v=*(it2+1);
> > > -//                 kDebug(9042) << "EXISTS" << v << *it2;
> > >                  if(v.isEmpty())
> > >                      kDebug(9042) << "error: no parameter to exist";
> > >                  else
> > >                  {
> > >                      last=false;
> > > -                    QFileInfo f(v);
> > > +                    QString dir;
> > > +                    if(m_vars->contains("CMAKE_CURRENT_SOURCE_DIR"))
> > > +
> >  dir=m_vars->value("CMAKE_CURRENT_SOURCE_DIR").first();
> > > +                    QFileInfo f(dir, v);
> >
> > Isn't this the same problem as the current-source-dir thing from your last
> > commit? That is if the argument is already an absolute path this will now
> > fail.
> 
> It is fine, just added tests for that.

Interesting, that should be better documented in the QFileInfo
constructor. I'll send a bugreport to QtSoftware.

Andreas

-- 
You have a strong appeal for members of the opposite sex.