Updating name for an IDocumentation
mail at milianw.de
Tue Dec 1 22:43:17 UTC 2009
On Tuesday 01 December 2009 23:13:40 Aleix Pol wrote:
> I guess it's fine. you can create a patch and send it to the review board.
> We can discuss it there.
> IDocumentation is thought to be autocontented. I guess this is just a
> problem when you're navigating.
Yes, exactly. It's only a problem when navigating.
> Can't you extract the title from the URL?
Generally: No. And if, it would be just one big guess and might fail horribly
under certain circumstances.
> Otherwise you're forcing the ::name method to have no validity until the
> widget is loaded.It's not meant to be unique but having it changeable might
> be disappointing.
The name is used for displaying something, it's not an identifier. So what's
wrong with changing it eventually?
> Or maybe you could create the part when the IDocumentation is created, but
> that would be a performance loss...
Hm, what do you mean here? I do create the part, but it takes time until the
HTML gets loaded. Or do you want me to wait for loading before returning?
I'd really hate that, one more case where a syncronous API is forced on a
async API... This just makes things lag, and would also kill my "...loading...
[progressbar]" indicator useless (well, unfunctional).
I'll come up with a patch and submit it to reviewboard. BTW: Is that already
working with kdevplatform having moved to extragear?
> On Tue, Dec 1, 2009 at 8:44 PM, Milian Wolff <mail at milianw.de> wrote:
> > Hey all, esp. Apol:
> > Since I use a KHTML-Part to embed the remote PHP documentation, the user
> > can
> > freely click on links and the requested document gets loaded. Right now,
> > as soon as a link gets clicked, I don't know what to use as name. I just
> > leave it
> > empty, which also means the lineedit on top stays empty.
> > I'd greatly prefer if I could set the name later on (i.e. once I know the
> > <title> of the loaded document). Can I add some signal to the
> > IDocumentation
> > and make the controller listen to it. Didn't look into the code but imo
> > it should kinda work out I think. Alternatively some method I can could
> > call via
> > ICore::self()->documentationController()->... would be OK for me as well,
> > whatever you prefer.
mail at milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: This is a digitally signed message part.
More information about the KDevelop-devel