Review Request: Refactor parts of GenericManager for symlinks and less hacks
Milian Wolff
mail at milianw.de
Tue Aug 18 13:17:59 UTC 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1351/
-----------------------------------------------------------
Review request for KDevelop.
Summary
-------
Leverage the changes of r1012521 and remove some hacks. Additionally support symlinked folders and don't use listDirRecursive but instead listDir. The former is easier but walks into folders even if they get filtered.
Thanks to g-zu (Radu Benea) for most of the work on this patch.
TODO: make sure recursive symlinks don't crash
Diffs
-----
trunk/KDE/kdevplatform/plugins/genericprojectmanager/genericmanager.h 1012930
trunk/KDE/kdevplatform/plugins/genericprojectmanager/genericmanager.cpp 1012930
Diff: http://reviewboard.kde.org/r/1351/diff
Testing
-------
tested basic projects with some symlinks. remote stuff also works like a charm
big projects work not so good though that was like that even beforehand. Especially the GUI hangs for a short delay when adding new items to the project it seems, hence big folders can hang the GUI a bit of time... Though I don't see a way around that while using KIO since it has to use the GUI thread, right?
Or would it be possible to push the actual adding, filtering etc. of items to a background thread?
Thanks,
Milian
More information about the KDevelop-devel
mailing list