Review Request: Fixes to allow kdevplatform to run on Windows

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1273/#review1984
-----------------------------------------------------------



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/namespacealiasdeclaration.cpp
<http://reviewboard.kde.org/r/1273/#comment1322>

    This change doesn't look correct. If this doesn't work on windows, you need to find out why it doesn't work, just disabling the code is not ok.



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/namespacealiasdeclaration.cpp
<http://reviewboard.kde.org/r/1273/#comment1323>

    Same as above.



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/repositories/typerepository.cpp
<http://reviewboard.kde.org/r/1273/#comment1325>

    You need to update your patch, this has been fixed differently already in trunk.



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/topducontext.cpp
<http://reviewboard.kde.org/r/1273/#comment1324>

    Again, this is not acceptable, find out what the problem is in the code and fix it.



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/sublime/mainwindow_p.cpp
<http://reviewboard.kde.org/r/1273/#comment1326>

    another of those "moving *" changes thats uneeded.


I think the rest is ok, though I'd like to hear Davids comments on the modificationrevisionset.cpp changes (i.e. regarding the static repository change there).

- Andreas


On 2009-08-11 13:47:03, Yaron Hirsch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1273/
> -----------------------------------------------------------
> 
> (Updated 2009-08-11 13:47:03)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Fixes to allow kdevplatform to run on Windows
> Changes to remove warnings in MSVC regarding types first defined as class/struct but declared as class/struct.
> There's another review for kdevelop regarding this bug.
> 
> 
> This addresses bug 201455.
>     https://bugs.kde.org/show_bug.cgi?id=201455
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/CMakeLists.txt 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/backgroundparser/parsejob.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/codecompletion/codecompletionitem.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/codecompletion/codecompletionmodel.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/codegen/applychangeswidget.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/codegen/codegenerator.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/codegen/createclass.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/codegen/documentchangeset.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/appendedlist.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/codemodel.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/definitions.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/duchainbase.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/ducontext.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/dumpdotgraph.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/functiondefinition.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/identifier.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/importers.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/instantiationinformation.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/namespacealiasdeclaration.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/persistentsymboltable.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/repositories/typerepository.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/topducontext.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/types/typesystemdata.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/use.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/duchain/uses.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/editor/modificationrevisionset.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/editor/simplecursor.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/editor/simplerange.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/util/basicsetrepository.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/language/util/setrepository.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/plugins/genericprojectmanager/genericmanager.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/project/projectmodel.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/shell/partdocument.cpp 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/shell/textdocument.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/sublime/mainwindow.h 1007941 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevplatform/sublime/mainwindow_p.cpp 1007941 
> 
> Diff: http://reviewboard.kde.org/r/1273/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yaron
> 
>