Review Request: Fixes to allow KDevelop to run on Windows

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1270/#review1983
-----------------------------------------------------------



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/CMakeLists.txt
<http://reviewboard.kde.org/r/1270/#comment1318>

    Huh? I can't see boost being used in the rest of the patch, so surely this was accidental right?



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/CMakeLists.txt
<http://reviewboard.kde.org/r/1270/#comment1319>

    Related to the above I guess.



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/languages/cpp/cppduchain/contextbuilder.cpp
<http://reviewboard.kde.org/r/1270/#comment1320>

    I hope msvc didn't choke on this, because either way is valid. These 4 changes should be reverted.



svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/languages/cpp/cppduchain/declarationbuilder.cpp
<http://reviewboard.kde.org/r/1270/#comment1321>

    same as the other.


The rest looks fine, so only things to fix are all the moved "*" and the cmake file

- Andreas


On 2009-08-11 13:43:04, Yaron Hirsch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1270/
> -----------------------------------------------------------
> 
> (Updated 2009-08-11 13:43:04)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Fixes to allow KDevelop to run on Windows.
> Changes to remove warnings in MSVC regarding types defined as class/struct but declared as struct/class.
> There exists another review for kdevplatform regarding this.
> 
> 
> This addresses bug 201455.
>     https://bugs.kde.org/show_bug.cgi?id=201455
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/CMakeLists.txt 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/languages/cpp/cppduchain/contextbuilder.cpp 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/languages/cpp/cppduchain/declarationbuilder.cpp 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/languages/cpp/cppduchain/environmentmanager.h 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/languages/cpp/cppduchain/overloadresolutionhelper.h 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/languages/cpp/cppduchain/qtfunctiondeclaration.h 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/languages/cpp/cppduchain/typebuilder.cpp 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/languages/cpp/cppduchain/typeconversion.h 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/languages/cpp/cppduchain/typeconversion.cpp 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/languages/cpp/includeitem.h 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/languages/cpp/parser/ast.h 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/languages/cpp/parser/listnode.h 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/languages/cpp/parser/rpp/pp-macro.h 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/languages/cpp/tests/test_cppcodecompletion.cpp 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/projectmanagers/cmake/parser/cmakelistsparser.h 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/projectmanagers/cmake/parser/cmakeprojectvisitor.cpp 1007942 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdevelop/projectmanagers/custommake/custommakemodelitems.h 1007942 
> 
> Diff: http://reviewboard.kde.org/r/1270/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yaron
> 
>