[PATCH]: Silent some warnings in kdevplatform

Milian Wolff mail at milianw.de
Tue Aug 11 14:48:30 UTC 2009


Stefan Valouch wrote:
> On Sunday 09 August 2009 20:32:30 Aleix Pol wrote:
>> On Sun, Aug 9, 2009 at 6:36 PM, Stefan Valouch <stefan at valouch.de> wrote:
>>> On Sunday 09 August 2009 18:18:05 Aleix Pol wrote:
>>>>> It would be much better if you posted that on the reviewboard.
> 
> I tried, found a script to convert the git-svn diffs to svn diffs so that 
> reviewboard accepts it, but it now tells me: 
> The file 'kdevplatform/debugger/framestack/framestackmodel.cpp' (r1009970) 
> could not be found in the repository
> 
>> Well, the only thing that stops you from being a kde developer is that
>> account. If you want to work on any code in kdevelop, it would be good you
>> got one.
>>
> I don't think that I'm experienced enough for an account (both in terms of 
> C++-knowledge and KDE-knowledge), and I think that my patches should be 
> reviewed before being applied to avoid damage to the codebase.
> 
> Stefan

You can commit the stuff yourself once it's reviewed.

And you can always post patches to the ML here for review. That's no 
problem.

I did that like that myself and got more and more confident in my 
abilities. Nowadays I only let my stuff reviewed if I'm really not sure.

Go, get a SVN account. Now! :D YES YOU CAN :)

-- 
Milian Wolff
http://milianw.de




More information about the KDevelop-devel mailing list