PartDocument location

[Aleix Pol]

On Mon, Aug 10, 2009 at 12:23 AM, Andreas Pakulat <apaku at gmx.de> wrote:

> On 09.08.09 23:44:42, Andreas Pakulat wrote:
> > On 09.08.09 21:30:02, Aleix Pol wrote:
> > > Hi,
> > > Do you think it would be possible to move the PartDocument somewhere
> else
> > > (like in kdevplatform/util) so that we can create new document
> instances
> > > with it?
> >
> > No, rather it should move to interfaces IMHO, thats basically the
> > "public API" of shell. One downside is that this means interfaces links
> > against sublime and hence each plugin links against sublime too.
> >
> > That would (hopefully) also allow to remove some duplicated code between
> > PartDocument, TextDocument and DesignerDocument (currently in
> > playground)
>
> You also might hit problems where PartDocument uses shell-internal API.
> Please try to keep as much of that inside shell as possible...
>
> Hmm, is there any reason not to implement a KDevKompareDocument directly
> inside shell, instead of in a plugin? Because I'm not overly comfortable
> to create new public API for just 1 specific case, that'll need quite
> some thinking on what is needed also in other cases
>
> Andreas
>
> --
> You love peace.
>
> _______________________________________________
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>

Yes, that's what I ended up by doing. I moved the PatchDocument to the shell
and created a IPatchDocument as an interface and seems to work just fine.

Now i'm getting some ghost crash that's driving me mad... gaaah xD
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20090810/d47bc58f/attachment.html>