[PATCH]: Silent some warnings in kdevplatform

Stefan Valouch stefan at valouch.de
Sun Aug 9 16:36:00 UTC 2009


On Sunday 09 August 2009 18:18:05 Aleix Pol wrote:
> On Sun, Aug 9, 2009 at 6:03 PM, Stefan Valouch <stefan at valouch.de> wrote:
> > Hi,
> > the attached patch silents a bunch of warnings from g++ (4.4.1).
> > Mostly, it puts Q_UNUSED() around parameters and add some brackets where
> > g++
> > suggested them. I tried to stay conform to the formatting styles around
> > the changed positions.
> > On positions where the parameters were just used in Q_ASSERTs, I did not
> > add
> > Q_UNUSED, cause I did not want to break something.
> > Additionally, a comment is added at
> > kdevplatform/language/editor/modificationrevision.cpp about the include
> > of a
> > (now) deprecated header.
> >
> > Compiles successfully and KDevelop is happy with it.
> >
> > Stefan
> >
> > _______________________________________________
> > KDevelop-devel mailing list
> > KDevelop-devel at kdevelop.org
> > https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
> >
> > It would be much better if you posted that on the reviewboard.
> 
> I just browsed over the patch nad doesn't look bad to me.
> 
> Do you have a svn account?
> 

No, I'm not a KDE developer :-)




More information about the KDevelop-devel mailing list