Java language support

[Milian Wolff]

Stefan Valouch, 07.08.2009:
> On Friday 07 August 2009 18:31:25 Milian Wolff wrote:
> > Stefan Valouch, 07.08.2009:
> > > On Tuesday 04 August 2009 14:26:12 Aleix Pol wrote:
> > > > On Tue, Aug 4, 2009 at 2:07 PM, Andreas Pakulat <apaku at gmx.de> wrote:
> > > > > Don't worry, I'll just commit it as is, but keep that in mind for
> > > > > the next patch :)
> > >
> > > Okay. I just generated two diffs containing the same like the original
> > > (deleted that to avoid confusion), so here are they:
> > > make the plugin compile: patches/kde/playground-
> > > devtools/make_plugin_compile.patch
> > > silent some g++ warnings: patches/kde/playground-
> > > devtools/silent_warnings.patch
> >
> > You forgot to attach the patches.
>
> Uh right, sorry.
>
> make the plugin compile: http://valouch.info/patches/kde/playground-
> devtools/make_plugin_compile.patch

+  m_followingText = followingText;

=> use the init-list here, i.e.:

   , m_memberAccessOperation(NoMemberAccess), m_followingText(followingText)

The m_knownArgumentExpressions is not assigned to at all, put it up here as 
well.

But regarding the latter: I don't know where you got all those arguments from 
for the ctor of the codecompletioncontext. In PHP we just have:

CodeCompletionContext(KDevelop::DUContextPointer context, const QString& text, 
const QString& followingText, const KDevelop::SimpleCursor& position, int 
depth = 0);

> silent some g++ warnings: http://valouch.info/patches/kde/playground-
> devtools/silent_warnings.patch

Else everything looks good to me.

-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20090808/b7e13005/attachment.sig>