[Patch] Ui cleanups for Project View plugin

Peter Oberndorfer kumbayo84 at arcor.de
Tue Apr 14 19:09:29 UTC 2009


On Dienstag 14 April 2009, Sean Harmer wrote:
> Hi All,

Hi

> Please find attached a patch that makes some small ui changes to the Project 
> View plugin. These are mainly related to the build set widget where I have 
> moved the build set item manipulation buttons to be above the widget to save 
> horizontal space and reduce the cluttered look (especially when there are 
> adjacent docks open in the bottom dock area).
> 
> I have also replaced the QTableView with a QTreeView so that we get better 
> behaviour when hovering over items. That is the whole row is highlighted by 
> the style rather than a single cell.
> 

I have also worked a bit with the buildset widget, and i also came to the conclusion
that i like the QTreeView better.

> I have also made the columns in the build set widget adjust themselves to 
> their content whenever items are added or removed.
> 
> The only change in the outer widget's ui file is to remove an extraneous level 
> of layout.
> 
> Please see screen-shot 
> (http://img299.imageshack.us/img299/6539/kdevelopprojectview.png) for how the 
> project view plugin looks now.
> 
> Can somebody review and commit if it is OK please?
> 

I attached my patches for the project buildset widget.
Please give some review/comments.
I have a SVN account...

The patch 1 fixes a assert from happening when a element is already on top
and pressing the up button, by disabling the button in this case.

For the other patches the patch description should be good enough.

First i wanted to put them on reviewboard, but it does not like my git patches
"No valid separator after the filename was found in the diff header" :-(

Greetings Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-do-not-enable-up-down-buttons-in-buildset-when-movin.patch
Type: text/x-diff
Size: 2243 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20090414/6857160c/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-fix-ProjectBuildSetModel-moveRowsToBottom-moveRowsTo.patch
Type: text/x-diff
Size: 1462 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20090414/6857160c/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-remove-the-default-margin-from-project-manager-view.patch
Type: text/x-diff
Size: 2864 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20090414/6857160c/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-iterate-over-ProjectBuildSetModel-in-reverse-order-w.patch
Type: text/x-diff
Size: 1507 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20090414/6857160c/attachment-0003.bin>


More information about the KDevelop-devel mailing list