[Patch] Qmake project manager Qt module include paths

[Sean Harmer]

On Sunday 12 April 2009 00:35:23 Andreas Pakulat wrote:
> On 10.04.09 16:40:28, Sean Harmer wrote:
> > That's fine I'm just not very familiar with the kdevplatform code base
> > yet. Could you give me a pointer as to where to look for this environment
> > support please?
>
> Its a class in kdevplatform/util/, check qmakebuilder in
> kdevelop/projectbuilders. It uses the combobox for the kcm and the class
> for extracting the
> environment.
OK I'll take a look thanks.

> > > This part is ok design-wise, but the conversion from QByteArray to
> > > QString is broken - I suggest to make sure that qmake runs in an UTF8
> > > locale and then use QString::fromUtf8().
> >
> > Fair enough, do you have a preferred way of launching apps with QProcess
> > in a UTF-8 locale?
>
> Hmm, actually, there's no good way to do this. There's no "general
> purpose" utf8 locale thats always enabled. So just make sure you convert
> using QString::fromLocal8Bit, which uses the locale in which KDevelop
> was started.
Second attempt at patch attached that only does the qmake include path 
resolution using qmake and appends subdirs based upon selected Qt modules. 
Please review and commit if it is OK.

Cheers,

Sean
-------------- next part --------------
A non-text attachment was scrubbed...
Name: qt-module-include-paths.patch
Type: text/x-patch
Size: 4419 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20090412/d0ded301/attachment.patch>