Review Request: VCS: Speedup the check for non-existant git-repositories
David Nolden
zwabel+reviewboard at gmail.com
Tue Apr 7 08:44:44 UTC 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/532/#review853
-----------------------------------------------------------
We should do these checks whenever possible with a VCS system. We should even do it if it doesn't bring a speedup(Although it most certainly will), because if we call for example the "git" executable, it has to be loaded including all its dependent libraries, which can be really slow on a cold cache, and pollutes the cache with content we just don't need if the vcs is not used.
- David
On 2009-04-06 11:08:09, Fabian Wiesel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/532/
> -----------------------------------------------------------
>
> (Updated 2009-04-06 11:08:09)
>
>
> Review request for KDevelop.
>
>
> Summary
> -------
>
> In the case that a directory is not under the control of git, a check whether a directory is under version control accounts roughly 40ms of a total 70ms (Peak ~200ms) in the creation of a context menu.
> By first checking for the existence of a .git directory in all parent directories, one avoids the call to an external program. Should a correctly named directory be found, the external program is still called, which does a more sophisticated check.
>
> In my limited "benchmark", the additional calling costs seem to be up to 1ms.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdevplatform/plugins/git/gitplugin.cpp 950241
>
> Diff: http://reviewboard.kde.org/r/532/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Fabian
>
>
More information about the KDevelop-devel
mailing list