Review Request: VCS: Speedup the check for non-existant git-repositories

[Fabian Wiesel]

> On 2009-04-06 14:43:21, Andreas Pakulat wrote:
> > How deep was your test tree? I suggest to take a directory hierarchy thats at least 100 levels deep (counted from the .git directory, not '/') as "worst case" scenario.

The tree was fairly flat, only 4 directories deep from the root, 4 directories into the repository.


Directory depth 100:
         With    Without patch
Non-git: 5-6ms   20-25ms
Git:     30ms    14-20ms

Directory depth 200:
          With       without patch
non-git:  15-45ms    30-60ms
git    :  90ms-132ms 14-20ms


On a NFS share, and a directory  depth of roughly 100, the time with the patch applied is 25-50ms instead of 30-80ms.


> On 2009-04-06 14:43:21, Andreas Pakulat wrote:
> > /trunk/KDE/kdevplatform/plugins/git/gitplugin.cpp, line 82
> > <http://reviewboard.kde.org/r/532/diff/1/?file=5065#file5065line82>
> >
> >     Did you verify that cdUp() returns false when hitting '/'?

Yes.


- Fabian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/532/#review848
-----------------------------------------------------------


On 2009-04-06 11:08:09, Fabian Wiesel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/532/
> -----------------------------------------------------------
> 
> (Updated 2009-04-06 11:08:09)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> In the case that a directory is not under the control of git, a check whether a directory is under version control accounts roughly 40ms of a total 70ms (Peak ~200ms) in the creation of a context menu.
> By first checking for the existence of a .git directory in all parent directories, one avoids the call to an external program.  Should a correctly named directory be found, the external program is still called, which does a more sophisticated check.
> 
> In my limited "benchmark", the additional calling costs seem to be up to 1ms.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevplatform/plugins/git/gitplugin.cpp 950241 
> 
> Diff: http://reviewboard.kde.org/r/532/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fabian
> 
>