Review Request: VCS: Extend the specification of checkout to encompass the DVCS case, renamed checkout() to createWorkingCopy()

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/526/#review843
-----------------------------------------------------------

Ship it!


ok, looks good.

- Andreas


On 2009-04-06 10:37:30, Fabian Wiesel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/526/
> -----------------------------------------------------------
> 
> (Updated 2009-04-06 10:37:30)
> 
> 
> Review request for KDevelop and Andreas Pakulat.
> 
> 
> Summary
> -------
> 
> As I see it, the current IBasicVersionControl::checkout() function is used to create an initial "checkout" from a remote repository.
> In case for a DVCS, the closest operation is clone(), which additionally to creating a working copy, also entails the creation of a local copy of the remote repository.
> 
> For DVCS the term "checkout" maps to the operation the IBasicVersionControl::update().
> 
> In order to avoid confusion, I suggest renaming IBasicVersionControl::checkout() to createWorkingCopy().
> 
> Also, as the result IDistributedVersionControl::clone() fulfils all requirements one has on createWorkingCopy(), one can consider it 
> a duplicate of createWorkingCopy() and therefore remove it.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevplatform/plugins/appwizard/appwizardplugin.cpp 950241 
>   /trunk/KDE/kdevplatform/plugins/cvs/cvsplugin.h 950241 
>   /trunk/KDE/kdevplatform/plugins/cvs/cvsplugin.cpp 950241 
>   /trunk/KDE/kdevplatform/plugins/git/gitplugin.h 950241 
>   /trunk/KDE/kdevplatform/plugins/git/gitplugin.cpp 950241 
>   /trunk/KDE/kdevplatform/plugins/git/tests/initTest.cpp 950241 
>   /trunk/KDE/kdevplatform/plugins/mercurial/mercurialplugin.h 950241 
>   /trunk/KDE/kdevplatform/plugins/mercurial/mercurialplugin.cpp 950241 
>   /trunk/KDE/kdevplatform/plugins/mercurial/tests/initTest.cpp 950241 
>   /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.h 950241 
>   /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.cpp 950241 
>   /trunk/KDE/kdevplatform/shell/kross/krossdistributedversioncontrol.h 950241 
>   /trunk/KDE/kdevplatform/shell/kross/krossdistributedversioncontrol.cpp 950241 
>   /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.h 950241 
>   /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.cpp 950241 
>   /trunk/KDE/kdevplatform/vcs/interfaces/ibasicversioncontrol.h 950241 
>   /trunk/KDE/kdevplatform/vcs/interfaces/idistributedversioncontrol.h 950241 
>   /trunk/KDE/kdevplatform/vcs/tests/vcsBlackBoxTest.cpp 950241 
> 
> Diff: http://reviewboard.kde.org/r/526/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fabian
> 
>