Review Request: Each VcsPlugin its own context menu, Changed the VcsCommonPlugin to a helper class for common functionality

Fabian Wiesel fabian.wiesel at googlemail.com
Sun Apr 5 21:15:57 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/530/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

Separating the menus allows one to operate concurring VCSs simultaneously.
Also for each file in the context of contextMenuExtension() call, the VcsPlugin had to check twice if a file is under version control.
First, for VcsCommonPlugin::contextMenuExtension(), second time for its own. So the context-menu should be a bit more speedier.

Also, by making VcsCommonPlugin a helper class, the conversion of the various contexts happens in one place.


Diffs
-----

  /trunk/KDE/kdevplatform/plugins/cvs/cvsplugin.h 949557 
  /trunk/KDE/kdevplatform/plugins/cvs/cvsplugin.cpp 949557 
  /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.h 949557 
  /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.cpp 949557 
  /trunk/KDE/kdevplatform/plugins/vcscommon/CMakeLists.txt 949557 
  /trunk/KDE/kdevplatform/plugins/vcscommon/Messages.sh 949557 
  /trunk/KDE/kdevplatform/plugins/vcscommon/kdevvcscommon.desktop 949557 
  /trunk/KDE/kdevplatform/plugins/vcscommon/kdevvcscommonplugin.h 949557 
  /trunk/KDE/kdevplatform/plugins/vcscommon/kdevvcscommonplugin.cpp 949557 
  /trunk/KDE/kdevplatform/vcs/CMakeLists.txt 949557 
  /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.h 949557 
  /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.cpp 949557 
  /trunk/KDE/kdevplatform/vcs/vcspluginhelper.h 949557 
  /trunk/KDE/kdevplatform/vcs/vcspluginhelper.cpp 949557 

Diff: http://reviewboard.kde.org/r/530/diff


Testing
-------


Thanks,

Fabian





More information about the KDevelop-devel mailing list