Review Request: VCS::checkout()/import() Replace the VcsMapping argument with a pair of arguments VcsLocation and KUrl

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/512/#review814
-----------------------------------------------------------

Ship it!


Looks fine, please commit.

- Andreas


On 2009-04-04 01:50:26, Fabian Wiesel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/512/
> -----------------------------------------------------------
> 
> (Updated 2009-04-04 01:50:26)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This eases the requirements on the individual VCS-plugins and makes the requirements on the arguments more explicit. All current callers require only this sub-set. Unfortunately, it touches a lot of code.
> Does a non-recursive import make sense? I simply adopted the feature from VcsMapping.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevplatform/plugins/appwizard/appwizarddialog.h 948900 
>   /trunk/KDE/kdevplatform/plugins/appwizard/appwizarddialog.cpp 948900 
>   /trunk/KDE/kdevplatform/plugins/appwizard/appwizardplugin.cpp 948900 
>   /trunk/KDE/kdevplatform/plugins/appwizard/projectvcspage.h 948900 
>   /trunk/KDE/kdevplatform/plugins/appwizard/projectvcspage.cpp 948900 
>   /trunk/KDE/kdevplatform/plugins/cvs/checkoutdialog.cpp 948900 
>   /trunk/KDE/kdevplatform/plugins/cvs/cvsplugin.h 948900 
>   /trunk/KDE/kdevplatform/plugins/cvs/cvsplugin.cpp 948900 
>   /trunk/KDE/kdevplatform/plugins/cvs/importdialog.cpp 948900 
>   /trunk/KDE/kdevplatform/plugins/cvs/importmetadatawidget.h 948900 
>   /trunk/KDE/kdevplatform/plugins/cvs/importmetadatawidget.cpp 948900 
>   /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.h 948900 
>   /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.cpp 948900 
>   /trunk/KDE/kdevplatform/plugins/subversion/svncheckoutjob.h 948900 
>   /trunk/KDE/kdevplatform/plugins/subversion/svncheckoutjob.cpp 948900 
>   /trunk/KDE/kdevplatform/plugins/subversion/svncheckoutjob_p.h 948900 
>   /trunk/KDE/kdevplatform/plugins/subversion/svncheckoutmetadatawidget.h 948900 
>   /trunk/KDE/kdevplatform/plugins/subversion/svncheckoutmetadatawidget.cpp 948900 
>   /trunk/KDE/kdevplatform/plugins/subversion/svnimportjob.h 948900 
>   /trunk/KDE/kdevplatform/plugins/subversion/svnimportjob.cpp 948900 
>   /trunk/KDE/kdevplatform/plugins/subversion/svnimportjob_p.h 948900 
>   /trunk/KDE/kdevplatform/plugins/subversion/svnimportmetadatawidget.h 948900 
>   /trunk/KDE/kdevplatform/plugins/subversion/svnimportmetadatawidget.cpp 948900 
>   /trunk/KDE/kdevplatform/plugins/subversion/ui/importmetadatawidget.ui 948900 
>   /trunk/KDE/kdevplatform/shell/kross/krossdistributedversioncontrol.h 948900 
>   /trunk/KDE/kdevplatform/shell/kross/krossdistributedversioncontrol.cpp 948900 
>   /trunk/KDE/kdevplatform/vcs/CMakeLists.txt 948900 
>   /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.h 948900 
>   /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.cpp 948900 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/importdialog.cpp 948900 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/importmetadatawidget.h 948900 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/importmetadatawidget.cpp 948900 
>   /trunk/KDE/kdevplatform/vcs/interfaces/ibasicversioncontrol.h 948900 
>   /trunk/KDE/kdevplatform/vcs/interfaces/icentralizedversioncontrol.h 948900 
>   /trunk/KDE/kdevplatform/vcs/tests/vcsBlackBoxTest.cpp 948900 
>   /trunk/KDE/kdevplatform/vcs/vcsmapping.h 948900 
>   /trunk/KDE/kdevplatform/vcs/vcsmapping.cpp 948900 
>   /trunk/KDE/kdevplatform/vcs/widgets/vcsimportmetadatawidget.h 948900 
> 
> Diff: http://reviewboard.kde.org/r/512/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fabian
> 
>