Review Request: VCS::checkout()/import() Replace the VcsMapping argument with a pair of arguments VcsLocation and KUrl

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/512/#review811
-----------------------------------------------------------



/trunk/KDE/kdevplatform/plugins/appwizard/appwizarddialog.h
<http://reviewboard.kde.org/r/512/#comment495>

    Is there any usecase where one would want to import only the top-level dir of a new project? I can't think of one, so IMHO this option and the virtuals on the metadata widget should just go and we should always to a recursive import.



/trunk/KDE/kdevplatform/plugins/appwizard/projectvcspage.cpp
<http://reviewboard.kde.org/r/512/#comment494>

    Hmm, just my personal preference probably but I find append() nicer than the stl-like push_back :)



/trunk/KDE/kdevplatform/plugins/mercurial/kdevmercurial.desktop
<http://reviewboard.kde.org/r/512/#comment496>

    Was the removal of these translations intentional?



/trunk/KDE/kdevplatform/vcs/interfaces/ibasicversioncontrol.h
<http://reviewboard.kde.org/r/512/#comment498>

    Right after committing your patch, please move this method to the ICVCS interface, it really doesn't make sense in this form for dvcs.


- Andreas


On 2009-04-03 12:20:38, Fabian Wiesel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/512/
> -----------------------------------------------------------
> 
> (Updated 2009-04-03 12:20:38)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This eases the requirements on the individual VCS-plugins and makes the requirements on the arguments more explicit. All current callers require only this sub-set. Unfortunately, it touches a lot of code.
> Does a non-recursive import make sense? I simply adopted the feature from VcsMapping.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevplatform/plugins/appwizard/appwizarddialog.h 948770 
>   /trunk/KDE/kdevplatform/plugins/appwizard/appwizarddialog.cpp 948770 
>   /trunk/KDE/kdevplatform/plugins/appwizard/appwizardplugin.cpp 948770 
>   /trunk/KDE/kdevplatform/plugins/appwizard/projectvcspage.h 948770 
>   /trunk/KDE/kdevplatform/plugins/appwizard/projectvcspage.cpp 948770 
>   /trunk/KDE/kdevplatform/plugins/cvs/checkoutdialog.cpp 948770 
>   /trunk/KDE/kdevplatform/plugins/cvs/cvsplugin.h 948770 
>   /trunk/KDE/kdevplatform/plugins/cvs/cvsplugin.cpp 948770 
>   /trunk/KDE/kdevplatform/plugins/cvs/importdialog.cpp 948770 
>   /trunk/KDE/kdevplatform/plugins/cvs/importmetadatawidget.h 948770 
>   /trunk/KDE/kdevplatform/plugins/cvs/importmetadatawidget.cpp 948770 
>   /trunk/KDE/kdevplatform/plugins/mercurial/kdevmercurial.desktop 948770 
>   /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.h 948770 
>   /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.cpp 948770 
>   /trunk/KDE/kdevplatform/plugins/subversion/svncheckoutjob.h 948770 
>   /trunk/KDE/kdevplatform/plugins/subversion/svncheckoutjob.cpp 948770 
>   /trunk/KDE/kdevplatform/plugins/subversion/svncheckoutjob_p.h 948770 
>   /trunk/KDE/kdevplatform/plugins/subversion/svncheckoutmetadatawidget.h 948770 
>   /trunk/KDE/kdevplatform/plugins/subversion/svncheckoutmetadatawidget.cpp 948770 
>   /trunk/KDE/kdevplatform/plugins/subversion/svnimportjob.h 948770 
>   /trunk/KDE/kdevplatform/plugins/subversion/svnimportjob.cpp 948770 
>   /trunk/KDE/kdevplatform/plugins/subversion/svnimportjob_p.h 948770 
>   /trunk/KDE/kdevplatform/plugins/subversion/svnimportmetadatawidget.h 948770 
>   /trunk/KDE/kdevplatform/plugins/subversion/svnimportmetadatawidget.cpp 948770 
>   /trunk/KDE/kdevplatform/shell/kross/krossdistributedversioncontrol.h 948770 
>   /trunk/KDE/kdevplatform/shell/kross/krossdistributedversioncontrol.cpp 948770 
>   /trunk/KDE/kdevplatform/vcs/CMakeLists.txt 948770 
>   /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.h 948770 
>   /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.cpp 948770 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/importdialog.cpp 948770 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/importmetadatawidget.h 948770 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/importmetadatawidget.cpp 948770 
>   /trunk/KDE/kdevplatform/vcs/interfaces/ibasicversioncontrol.h 948770 
>   /trunk/KDE/kdevplatform/vcs/interfaces/icentralizedversioncontrol.h 948770 
>   /trunk/KDE/kdevplatform/vcs/tests/vcsBlackBoxTest.cpp 948770 
>   /trunk/KDE/kdevplatform/vcs/vcsmapping.h 948770 
>   /trunk/KDE/kdevplatform/vcs/vcsmapping.cpp 948770 
>   /trunk/KDE/kdevplatform/vcs/widgets/vcsimportmetadatawidget.h 948770 
> 
> Diff: http://reviewboard.kde.org/r/512/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fabian
> 
>