[patch] codebrowser minor ui changes

[Manuel Breugelmans]

On Friday 28 November 2008 23:59:59 David Nolden wrote:
> Am Freitag, 28. November 2008 12:14:35 schrieb M Breugelmans:
> > Turns out there also a crash+leak in trunk
> > ContextBrowserView+ContextController. Attached patch fixes that, too.
>
> Why is there all that headerExtension, sourceExtension, etc. stuff? That's
> C++ specific and doesn't belong into kdevplatform..

Yes, the fact that this pops up in multiple places is a clear sign that it's 
missing from the language api. So if someone adds it there then this use here 
should be replaced, obviously.

> About the buttons, actually I like it that they are on the left and right
> of the current context, because they are semantically conntected to the
> context. It's like on the left side you can get to previous contexts, and
> on the right side to next contexts. It would probably be better if the
> context dropdown had a limited or maybe fixed width, so the buttons are
> never pushed out of the widget by a too long function-name.
>

I suppose you could get away with a fixed length if the three completion dots 
(...) were to appear at the start rather than the end/middle. This way it will 
mostly be namespace names that get truncated, no drama there. Not sure how to 
fix that though.

If I have to choose between semantically consistent and pleasant to use the 
second wins though.


Manuel