Replacing QRegExp with CMake RegularExpression

[Andreas Pakulat]

On 04.11.08 20:30:06, Manuel Breugelmans wrote:
> On Tuesday 04 November 2008 20:17:17 Andreas Pakulat wrote:
> > On 02.11.08 02:59:06, Andreas Pakulat wrote:
> > > Hi,
> > >
> > > so I thought it might be interesting to try this out. Turned out to be a
> > > bit more complex than I initially thought and unfortunately it also
> > > introduces one regression with the kde4addunittest test. (I'm seeing an
> > > error message from RegularExpression about nested "*?+", so that might be
> > > a hint).
> > >
> > > Having done a quick time kdevelop like test the startup speed of kdevelop
> > > including loading of kdevplatform was reduced frmo 15 to 11 seconds on my
> > > old machine.
> > >
> > > The patch is attached for anyone to look at, whats a bit scary is the
> > > conversion between QString and char* for the RegularExpression class. I'm
> > > actually thinking about seeing wether converting to QChar helps with that
> > > or wether using that class drains performance again.
> >
> > I guess nobody really tried this out, right? Because at least here I get
> > an std::badalloc when trying to open kdevelop or kdevplatform. So for now,
> > no RegExp replacement as I think we have more pressing issues than the last
> > few seconds - besides probably none of us uses a release Qt build, which
> > might make QRegExp a lot faster.
> >
> > Andreas
> 
> I'm running with it and noticed no regressions, both kdevelop + kdevplatform 
> load just fine. Any special steps to reproduce?

No, I just tried to load kdevplatform and it crashed during that. Don't
have the backtrace, but it was during usage of the RegularExpression class.

Andreas
 
-- 
Don't let your mind wander -- it's too little to be let out alone.