Replacing QRegExp with CMake RegularExpression

Aleix aleixpol at gmail.com
Sun Nov 2 14:16:16 UTC 2008


Hi, looks like a pretty small patch, I'm ok with using it, makes sense to
me.

On Sun, Nov 2, 2008 at 2:59 AM, Andreas Pakulat <apaku at gmx.de> wrote:

> Hi,
>
> so I thought it might be interesting to try this out. Turned out to be a
> bit more complex than I initially thought and unfortunately it also
> introduces one regression with the kde4addunittest test. (I'm seeing an
> error message from RegularExpression about nested "*?+", so that might be a
> hint).

We might have to tweak the library usage maybe, but i think that we are on
the right path here.


>
> Having done a quick time kdevelop like test the startup speed of kdevelop
> including loading of kdevplatform was reduced frmo 15 to 11 seconds on my
> old machine.
>
Great!


>
> The patch is attached for anyone to look at, whats a bit scary is the
> conversion between QString and char* for the RegularExpression class. I'm
> actually thinking about seeing wether converting to QChar helps with that
> or wether using that class drains performance again.
>
.toAscii() works for me, why passing through QChar?


>
> Andreas
>
> --
> You have the power to influence all with whom you come in contact.
>
> _______________________________________________
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20081102/cd4cd664/attachment.html>


More information about the KDevelop-devel mailing list