[CMake] Making FindBoost prefer Boost_ROOT

Matthew Woehlke mw_triad at users.sourceforge.net
Mon Mar 31 19:10:55 UTC 2008


Andreas Pakulat wrote:
> On 27.03.08 18:01:47, Matthew Woehlke wrote:
>> Andreas Pakulat wrote:
>>> However, looking at the fact that cmake itself uses all-upper-case for
>>> variables that can be specified on the commandline I'm going to  change
>>> these 3 too (there's also _INCLUDEDIR and _LIBRARYDIR)
>> Ok, makes sense. Actually if they are inputs, uppercase probably makes  
>> sense. Same-as-the-module case should of course be used for variables  
>> that are meant for consumption by the CMakeLists.txt that called  
>> findpackage(Boost), but I think _ROOT and friends are not in this 
>> category?
> 
> Exactly, those are all inputs to find_package.

I see this is cleaned up now; thanks!

>> AFAIK the one in kdevplatform is the only one in KDE's svn. I have  
>> others (which I now made symlinks to the kdevplatform one), because the  
>> one with my cmake, which those modules apparently use, is insufficient  
>> for me.
> 
> I thought kdepimlibs have their own...

Not as far as I know. Nor as far as my svn checkout claims :-).

>> If that won't be a maintenance issue for kdevelop, I'll probably plan to  
>> do it next week if no one has objected.
> 
> Not sure what you mean with that, moving this to kdelibs is not a
> problem for us.

Ok, I'll see about doing that soon-ish. I have a few other changes I'd 
like to propose first.

-- 
Matthew
I think I want my tombstone to read:
<name>
Process created <date of birth>
Signal 15 received <date of death>





More information about the KDevelop-devel mailing list