[patch] kdevelop desktop entry standard compliance

[Andreas Pakulat]

On 23.06.08 01:22:15, Carsten Lohrke wrote:
> On Sonntag, 22. Juni 2008, Andreas Pakulat wrote:
> > There are changes in there that might break things. Like removing the
> > encoding, are you sure that since KDE 3.4 all KDE versions assume utf-8
> > encoding of the files?
> 
> Likely, but I don't know for sure. My assumption is that the "only" users of 
> KDE 3.4 are the customers of distributors providing long term support for a 
> fixed set of packages. Given that KDE 3.4.3 has been released almost three 
> years ago in October 2005 and that we speak about the 3.5 branch here, from 
> my point of view thinking about users of KDE 3.4 beyond this limited and 
> commercially supported degree is questionable.
> 
> > > -DocPath=kdevelop/index.html
> > > +X-DocPath=kdevelop/index.html
> >
> > Is this used by khelpcenter? If so, does it still work with the changed
> > property? If its not khelpcenter, who uses this entry?
> 
> Yes. The whole desktop file handling is held in the KDesktopFile class within 
> kdecore. No application should parse the file itself and if it does, the 
> application is broken. I just had a look at the KDE 3.4.3 code and yes, it 
> reads X-DocPath as well.
> 
> > > -Exec=%{APPNAMELC} %i %m -caption "%c"
> > > +Exec=%{APPNAMELC} %i -caption "%c"
> >
> > I guess this change was unintentional, right?
> 
> No. %m is, among other fields, considerered deprecated and therefore not part 
> of the freedesktop.org desktop entry standard¹. Looking at kapplication.cpp 
> you see that the mini icon is derived from the normal icon, if not specified. 
> Given how many, many desktop entry files do not specify a mini icon, my bet 
> is that the KDE 3.4 code doesn't look very different.

Ok, thats good enough for me :) I'll commit that asap.

Andreas

-- 
There was a phone call for you.