KDE/kdevplatform/veritas

[Andreas Pakulat]

On 17.07.08 09:34:48, Manuel Breugelmans wrote:
> On Thursday 17 July 2008 09:28:19 Andreas Pakulat wrote:
> > On 17.07.08 09:10:04, Manuel Breugelmans wrote:
> > > On Thursday 17 July 2008 08:58:01 Andreas Pakulat wrote:
> > > > On 16.07.08 22:35:54, Carlo Segato wrote:
> > > > > SVN commit 833510 by segato:
> > > > >
> > > > > disable fvisibility=default on windows
> > > >
> > > > This doesn't look right (neither for win32 nor in general). It seems
> > > > the needed symbols are not properly exported. Manuel?
> > >
> > > I'm going to need a bit more information. That fvisiblity=default is
> > > conditional, for 'TestBuilds' only so I dont have to compile things twice
> > > to do proper unittesting of (otherwise hidden) library classes.
> >
> > Well, as you can see in the code its always on, which means the whole
> > library is exposed not only for tests.
> 
> The idea was to turn it off when doing a release build. Probably this can 
> somehow be fixed automatically with cmake?

Aah, right, totally forgot this. Unless I'm mistaken you only need this
when building the tests, right? Then you can just use the
KDE4_BUILD_TESTS cmake variable as a check, thats only set when one
builds the tests and thus you only export all symbols when test-building
is enabled.

Andreas

-- 
Excellent time to become a missing person.